53543[BUGFIX] respect curl ssl settings without curlProxyServer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 910
-
Benjamin Kluge uploaded patch set 1 07/19/17, 06:27
-
TYPO3com voted on patch set 1 V +1 07/19/17, 06:34 Completed build in 06m 44s on Wed, 19 Jul, 08:34 AM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1019
-
Mathias Brodala commented on patch set 1 CR -1 07/19/17, 07:24
Personally I totally agree with this change and even had to patch TYPO3 from time to time to achieve this, e.g. to disable certificate verification in a local dev environment with a snakeoil certificate. However, since this is relevant for security I'd like to request a 2nd opinion from the TYPO3 security team. -
Benjamin Kluge commented on patch set 1 07/19/17, 07:26
only 7.6 LTS uses curl directly. 8 and master uses guzzle -
Mathias Brodala commented on patch set 1 07/19/17, 07:40
> only 7.6 LTS uses curl directly. 8 and master uses guzzle Yes, I know, my remark wasn't about this. ;-) -
Oliver Hader commented on patch set 1 07/19/17, 08:46
I'd like to know about the exact use-cases here since the function has been extended like this in issue #75038. Please add those use-cases to the forge issue, thanks -
Nicole Hummel commented on patch set 1 07/19/17, 09:45
IMHO this is highly breaking. Not sure if we can simply add it to 7.6 release -
Benjamin Kluge commented on patch set 1 CR -1 07/19/17, 10:09
GeneralUtility.php:2473should only be set if $GLOBALS['TYPO3_CONF_VARS']['HTTP']['ssl_verify_host'] is set. Now its disabled peer and verify host if not set. And CURLOPT_SSL_VERIFYHOST is not a boolean it excepts 1 and 2 -
Benjamin Kluge commented on patch set 1 07/25/17, 20:42
maybe the same like https://review.typo3.org/#/c/49861/ -
Alexander Opitz abandoned the change 03/13/18, 10:53
Abandon in favor of https://review.typo3.org/#/c/49861/ which may also lead in abandon as it is a 7.6 only thing.