Review TYPO3_7-6 Merged

53571Revert "[BUGFIX] Escape value in FormEngine.removeOption selector"

Susi Moog CR +2 V +2 Easy +1 −1 updated 07/24/17, 06:39

Commit message

This reverts commit be38f08900bf927c1a3196d3a5e5c876db57828f.

escapeSelector is not available in jQuery 2.x

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Files 1

Review log 57

  1. Susi Moog uploaded patch set 1 07/24/17, 06:27

  2. Susi Moog updated the commit message in patch set 2 07/24/17, 06:27

  3. Markus Klein commented on patch set 2 07/24/17, 06:34

    Instead of reverting this. Can we fix that somehow correctly in the same go?
  4. TYPO3com voted on patch set 1 V +1 07/24/17, 06:35 Completed build in 08m 02s on Mon, 24 Jul, 08:35 AM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1025

  5. TYPO3com voted on patch set 2 V +1 07/24/17, 06:38 Completed build in 11m 11s on Mon, 24 Jul, 08:38 AM Test Summary: 38600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1026

  6. Susi Moog commented on patch set 2 CR +2 V +2 07/24/17, 06:39

    reverted because of wrong jQuery version in 7.6
  7. Gerrit merged patch set 2 07/24/17, 06:39