Review main Merged

53650[BUGFIX] YouTubeRenderer "controls" option

Česlav Przywara CR +2 V +2 Normal +92 −19 updated 08/15/17, 13:43

Commit message

The "controls" parameter appended to YouTube embed URL is either set to
value provided in $options array or to default backwards-compatible
value (controls=2).

Specifically, if controls option is set to 0, the controls parameter
must be present in URL, because default value for it is 1.

Fix is applied to related unit test too.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2