Review main Merged

53694[BUGFIX] Do not render <li> in section menu when CE has no header

Tymoteusz Motylewski CR +2 V +2 Easy +2 −0 updated 08/14/17, 17:53

Commit message

Section menu is now not rendering empty <li> when CE has no header.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Tymoteusz Motylewski uploaded patch set 1 08/14/17, 14:14

  2. TYPO3com voted on patch set 1 V +1 08/14/17, 14:24 Completed build in 10m 16s on Mon, 14 Aug, 04:24 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13693

  3. Benni Mack voted on patch set 1 CR +1 08/14/17, 16:47

  4. Georg Ringer voted on patch set 1 CR +1 V +1 08/14/17, 17:37

  5. Benni Mack voted on patch set 1 CR +2 V +2 08/14/17, 17:52

  6. Gerrit merged patch set 1 08/14/17, 17:52

  7. Benni Mack commented on patch set 2 08/14/17, 17:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 938a16807343cf47eba09ac742a2b565c448de17