Review main Merged

53739[BUGFIX] Preserve child order on IRRE localize/synchronize

Andreas Wolf CR +2 V +2 Hard +786 −49 updated 09/04/26, 15:37

Commit message

Localizing or synchronizing inline children appended freshly
translated records at the end of the child list. A child added
between two existing ones in the default language therefore
ended up last in the translation.

The child list of the localized parent is now rebuilt along the
default language children, mapping every original to its already
existing translation. Translations are sorted like their
originals, no matter when they were created. Children that only
exist in the translation keep the position they have relative to
the translated child they follow.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 6891

Show 5266 earlier messages
  1. Andreas Wolf uploaded patch set 1 08/19/17, 08:13

  2. TYPO3com voted on patch set 1 V -1 08/19/17, 08:13 Completed build in 11s on Sat, 19 Aug, 10:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13832

  3. Andreas Wolf uploaded patch set 2 08/19/17, 08:23

  4. TYPO3com voted on patch set 2 V +1 08/19/17, 08:34 Completed build in 10m 14s on Sat, 19 Aug, 10:34 AM Test Summary: 57593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13833

  5. Benni Mack commented on patch set 2 11/14/17, 08:28

    care to rebase?
  6. Andreas Wolf uploaded patch set 3 11/30/17, 10:14

  7. TYPO3com voted on patch set 3 V -1 11/30/17, 10:14 Completed build in 13s on Thu, 30 Nov, 11:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17084

  8. Andreas Wolf uploaded patch set 4 11/30/17, 10:29

  9. TYPO3com voted on patch set 4 V -1 11/30/17, 10:29 Completed build in 11s on Thu, 30 Nov, 11:29 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17087

  10. Andreas Wolf uploaded patch set 5 11/30/17, 10:33

  11. TYPO3com voted on patch set 5 V +1 11/30/17, 10:44 Completed build in 10m 40s on Thu, 30 Nov, 11:44 AM Test Summary: 57040 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17089

  12. Sybille Peters commented on patch set 5 V -1 02/15/18, 21:23

    Just to clarify: should the translated records have the same order of the originals after "Synchronize" is called once the patch is applied? (with translation in linked mode). This doesn't work for me.
  13. Sybille Peters wrote 02/15/18, 21:35

    Removed Verified-1 by Sybille Peters <sypets@gmx.de>
  14. Sybille Peters commented on patch set 5 V +1 02/15/18, 21:36

    Works with newly created elements (tested with bootstrap carousel from bootstrap_package).
  15. Markus Klein voted on patch set 5 CR +1 02/15/18, 21:55

  16. Andreas Kienast voted on patch set 5 CR +1 02/27/18, 19:08

  17. Stefan Neufeind voted on patch set 5 CR +1 03/12/18, 10:39

  18. Oliver Klee commented on patch set 5 03/12/18, 10:52

    ActionService.php:2

    strict, please

    TranslationSortingTestCase.php:2

    strict, please
  19. Markus Klein uploaded patch set 6 03/12/18, 22:40

  20. Markus Klein voted on patch set 6 CR +1 03/12/18, 22:40

  21. TYPO3com voted on patch set 6 V -1 03/12/18, 22:49 Completed build in 09m 29s on Mon, 12 Mar, 11:49 PM Test Summary: 30839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20873

  22. Markus Klein commented on patch set 6 V +1 03/12/18, 23:00

    don't know why the CSV shall be invalid as bamboo says... it does not say *why* it is invalid
  23. Markus Klein commented on patch set 7 03/12/18, 23:07

    Published edit on patch set 6.
  24. TYPO3com voted on patch set 7 V -1 03/12/18, 23:16 Completed build in 09m 08s on Tue, 13 Mar, 12:16 AM Test Summary: 30839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20875

  25. Markus Klein commented on patch set 7 03/12/18, 23:26

    To understand the CSV error without useless counting, checkout https://review.typo3.org/56124
  26. Markus Klein commented on patch set 7 CR -1 03/12/18, 23:37

  27. Markus Klein commented on patch set 8 03/13/18, 10:30

    Published edit on patch set 7.
  28. TYPO3com voted on patch set 8 V +1 03/13/18, 10:40 Completed build in 10m 15s on Tue, 13 Mar, 11:40 AM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20894

  29. Markus Klein voted on patch set 8 V +1 CR +1 03/13/18, 10:51

  30. Stefan Neufeind voted on patch set 8 CR +1 03/17/18, 17:13

  31. Stefan Neufeind commented on patch set 8 03/18/18, 16:23

    hmm, I tried to reproduce (verify) this patch but didn't find an issue on a non-patched master-branch.
  32. Tobi Kretschmann voted on patch set 8 CR +1 03/19/18, 09:55

  33. Sybille Peters commented on patch set 8 03/31/18, 21:48

    Stefan, I did test the patch a while back and it did work. I can still reproduce the problem in the latest master and the patch still works. I added the steps I used to reproduce to the issue: https://forge.typo3.org/issues/68040 I want to verify this though with a fresh installation, so I am not giving a +1 yet.
  34. Sybille Peters commented on patch set 8 03/31/18, 21:51

  35. Sybille Peters commented on patch set 8 V -1 04/01/18, 18:17

    This patch used to work but now does not in my tests with current master. I used my reproduce scenario: https://forge.typo3.org/issues/68040#note-21 It's a pity, but I assume too many other things changed in the meantime.
  36. Markus Klein voted on patch set 8 V 0 CR 0 04/01/18, 20:01

  37. Stefan Neufeind voted on patch set 8 CR 0 04/04/18, 12:47

  38. Benni Mack commented on patch set 8 11/02/18, 05:32

    Andreas, could you take another look here? Also, I opt for targeting master-only here now (since it's been over a year in review)
  39. Benni Mack updated the commit message in patch set 9 12/14/18, 10:06

  40. TYPO3com voted on patch set 9 V -1 12/14/18, 10:56 Completed build in 00s on Fri, 14 Dec, 11:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30702

  41. Andreas Wolf uploaded patch set 10 12/20/18, 11:32

  42. TYPO3com voted on patch set 10 V -1 12/20/18, 11:33 Completed build in 13s on Thu, 20 Dec, 12:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30942

  43. Andreas Wolf commented on patch set 10 12/20/18, 11:34

    The issue is still there, the test was just broken: because the test data set was missing l10n_source, all records were always translated (which was not verified by the test, my bad). Therefore, the sorting was of course always correct, so the patch actually did not change anything. Fixed the test data now, made the test more robust and also verified that the issue is still there when taking back the changes to DataHandler/RelationHandler.
  44. Andreas Wolf uploaded patch set 11 12/20/18, 11:34

  45. TYPO3com voted on patch set 11 V -1 12/20/18, 11:45 Completed build in 11m 14s on Thu, 20 Dec, 12:45 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30943

  46. Andreas Wolf uploaded patch set 12 12/20/18, 11:49

  47. TYPO3com voted on patch set 12 V +1 12/20/18, 12:05 Completed build in 15m 46s on Thu, 20 Dec, 01:05 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30944

  48. Markus Klein commented on patch set 12 12/22/18, 22:06

    @Benni: I would actually even propose the opposite: backport to v8 too ;-) That's yet another place where Core does stuff that can't be solved by the editor himself anymore. Thanks for the updates Andreas, will review things asap
  49. Andreas Kienast commented on patch set 12 05/06/19, 13:21

    *ping*
  50. Lorenz Ulrich commented on patch set 12 06/26/19, 08:39

    What's the status on this? It seems to have no votes, so I'm wondering if this won't be merged ever or if it's just not through review yet? I'm especially interested in a backport to v8.
  51. Markus Klein commented on patch set 12 06/26/19, 08:52

    Please review! Only missing reviews
  52. Tobi Kretschmann voted on patch set 12 CR +1 07/11/19, 14:27

  53. Tobi Kretschmann commented on patch set 12 07/12/19, 07:46

    How can I test this? Whatever I do, I always get the correct order. @Andreas: Do you have an extension to test this with?
  54. Markus Klein commented on patch set 12 07/12/19, 08:28

    > Patch Set 12: > > How can I test this? > Whatever I do, I always get the correct order. > @Andreas: Do you have an extension to test this with? You can test with gridelements for instance. Steps are the same as with https://forge.typo3.org/issues/68040#note-21
  55. Oliver Hader commented on patch set 12 CR -1 10/31/19, 15:37

    DataHandler.php:5093

    We should rather think about a generic method/service that supports multiple criteria that will lead to a distinct sorting partition - e.g. `('pid', 'l10n_parent', 'parent_id')`...

    TranslationSortingTestCase.php:88

    We should add to existing IRRE ForeignField tests and extend that to cover workspace versioning as well...
  56. Benni Mack wrote 04/06/20, 09:42

    Topic set to DataHandler
  57. Benni Mack updated the commit message in patch set 13 05/25/20, 18:46

  58. Benni Mack updated the commit message in patch set 14 11/18/21, 10:36

  59. Benni Mack wrote 11/29/21, 10:17

    Change destination moved from master to main
  60. Benni Mack updated the commit message in patch set 15 11/29/21, 14:08

  61. Oliver Klee wrote 11/29/21, 14:20

    Removed reviewer Oliver Klee.
  62. Benni Mack uploaded patch set 16 12/23/21, 09:40

  63. core-ci voted on patch set 16 V -1 12/23/21, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21415

  64. Benni Mack updated the commit message in patch set 17 V -1 05/03/23, 09:13

  65. core-ci voted on patch set 17 V -1 05/03/23, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41380

  66. Sybille Peters wrote 05/03/23, 12:41

    Removed reviewer Sybille Peters.
  1. Susi Moog uploaded patch set 18 V -1 07/05/23, 19:09

  2. Susi Moog uploaded patch set 19 07/05/23, 19:27

  3. core-ci voted on patch set 18 V -1 07/05/23, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43599

  4. Susi Moog uploaded patch set 20 V -1 07/05/23, 19:28

  5. core-ci voted on patch set 20 V -1 07/05/23, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43610

  6. core-ci voted on patch set 19 V -1 07/05/23, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43609

  7. Andreas Wolf uploaded patch set 21 V -1 07/06/23, 14:08

  8. core-ci voted on patch set 21 V -1 07/06/23, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43751

  9. Andreas Wolf uploaded patch set 22 V -1 07/06/23, 15:10

  10. core-ci voted on patch set 22 V -1 07/06/23, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43763

  11. Benni Mack updated the commit message in patch set 23 V -1 10/18/24, 14:08

  12. Benni Mack uploaded patch set 24 08/14/25, 06:13

  13. core-ci voted on patch set 24 V -1 08/14/25, 06:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83353

  14. Benni Mack wrote 04/21/26, 15:00

    Removed reviewer Benni Mack.
  15. Benni Mack updated the commit message in patch set 25 V -1 04/22/26, 06:53

  16. core-ci voted on patch set 25 V -1 04/22/26, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100822

  17. Benni Mack uploaded patch set 26 V -1 09/02/26, 06:31

  18. Benni Mack commented on patch set 26 09/02/26, 06:32

    TranslationSortingTestCase.php:88 Reply

    did that now
  19. core-ci voted on patch set 26 V +1 09/02/26, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107565

  20. Benni Mack uploaded patch set 27 V +1 09/02/26, 17:49

  21. Benni Mack commented on patch set 27 CR +1 V +1 09/02/26, 17:49

    DataHandler.php:5093 Reply

    I'll tackle the partioning part separately (7years and no progress :()
  22. core-ci voted on patch set 27 V +1 09/02/26, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107667

  23. Simon Schaufelberger voted on patch set 27 CR +1 V +1 09/03/26, 14:46

  24. Benni Mack voted on patch set 27 CR +2 V +2 09/04/26, 15:37

  25. Benni Mack merged patch set 28 09/04/26, 15:37