Review main Merged Breaking

53764[!!!][TASK] Extension manager: Drop "Download SQL Dump"

Christian Kuhn CR +2 V +2 Expert +66 −1543 updated 08/22/17, 19:10

Commit message

The em in "Installed Extensions" has a button "Download SQL Dump"
for all extensions that provide ext_tables.sql. On click, an sql
dump file is sent.

This feature is severely flawed:
* Dumps of extensions that add fields to existing tables contain
  a 'drop table' of these tables, the 'import into' statements are
  broken and only (try to) add these fields again. This easily
  leads to hazard in DB if importing such a dump.
* There are no charset specs and other meta data whatsoever in the dump.
* The dump is not dbal compatible, field definitions and imports
  are incomplete.

We assume nobody really used this feature in a sane way, even at
this prominent position in em. The lack of bug reports to this
broken feature and the fact there have been zero changes in this
area since main em refactoring years ago support this view.

There are way better options to retrieve proper data specifications:
* The list module has a csv export
* Ext:impexp supports export and import in a much better way
  including proper relation handling and other options.
* Low level db exports and backups should be done on cli or
  with more powerful guis like phpmyadmin or other db engine
  specific tools.

The feature is dropped without substitution.

The v8 backport of this patch will just remove the button from
the em list view, but keep all code.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14