53767[BUGFIX] Do not renumber unique keys in ArrayUtility
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Brodala +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 911
-
Susi Moog uploaded patch set 1 08/22/17, 10:15
-
Mathias Brodala commented on patch set 1 CR -1 08/22/17, 10:17
-
Susi Moog commented on patch set 1 08/22/17, 10:25
ArrayUtilityTest.php:1520Replyreordering would mean the strings are integers afterwards, but feel free to change the data set name to something more sensible ;) I'll struggled here, too, cause I wanted to use something more descriptive than "correctly". -
Mathias Brodala commented on patch set 1 08/22/17, 10:29
ArrayUtilityTest.php:1520ReplyI'll have a look. -
TYPO3com voted on patch set 1 V -1 08/22/17, 10:29 Completed build in 13m 38s on Tue, 22 Aug, 12:29 PM Test Summary: 3 of 58142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13901
-
Mathias Brodala uploaded patch set 2 08/22/17, 10:42
-
Mathias Brodala commented on patch set 2 08/22/17, 10:43
Restored compat with PHP 7.0, made test more obvious. -
TYPO3com voted on patch set 2 V +1 08/22/17, 10:54 Completed build in 12m 05s on Tue, 22 Aug, 12:54 PM Test Summary: 57779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13904
-
Mathias Brodala voted on patch set 2 CR +1 V +1 08/22/17, 11:02
-
Christian Kuhn voted on patch set 2 CR +2 V +2 08/22/17, 11:07
-
Gerrit merged patch set 2 08/22/17, 11:08
ArrayUtilityTest.php:1520