Review main Merged

53804[TASK] Install tool: Remove fatal error handling

Christian Kuhn CR +2 V +2 Normal +0 −112 updated 08/25/17, 08:46

Commit message

Before refactoring of the install tool with #76084, a
'fatal error handler' was in place to redirect to the
extension checker if a fatal php error was detected
during one of the main "tool" actions.
Now, the main controllers of the install tool never
load non-core extension data anymore, those can't
fail due to issues with specific ext_localconf.php or
ext_tables.php files. This extension loading now happens
only in ajax actions and thus can't kill the whole install
tool anymore.
Left over error handler code is removed from the
ToolController with this patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 4