Review main Merged

53805[BUGFIX] Only reorder integer keys in ArrayUtility

Susi Moog CR +2 V +2 Easy +1 −1 updated 08/31/17, 14:27

Commit message

PHP already converts strings representing 8-bit integers
to int - so there are no numeric array keys that are
of type string that ArrayUtility should reorder.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sascha Rademacher +1
    • Jan Stockfisch +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Susi Moog uploaded patch set 1 08/25/17, 05:19

  2. TYPO3com voted on patch set 1 V +1 08/25/17, 05:34 Completed build in 14m 34s on Fri, 25 Aug, 07:34 AM Test Summary: 58001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14013

  3. Oliver Klee commented on patch set 1 08/25/17, 10:02

    ArrayUtility.php:575

    Why not if (!is_int($key))?
  4. Jan Stockfisch commented on patch set 1 CR +1 08/25/17, 11:02

    ArrayUtility.php:575 Reply

    Using "=== false" is faster, because it does not need to check all types and possibilities first.
  5. Sascha Rademacher voted on patch set 1 CR +1 08/28/17, 08:11

  6. Jörg Bösche voted on patch set 1 CR +1 08/28/17, 09:16

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 08/31/17, 14:27

  8. Gerrit merged patch set 1 08/31/17, 14:27