Review main Merged

53837[TASK] Install Tool: Migrate authentication logic into AuthenticationService

Benni Mack CR +2 V +2 Hard +366 −317 updated 09/04/17, 09:38

Commit message

The PHP request flow logic for authentication against the install tool password
is moved into a new class called AuthenticationService.

Additionally, all logic which is only needed inside the StepController is moved
from the AbstractController into the StepController or the recovery request handler.

ToolController and AjaxController are now free of session handling completely.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7