Review main Merged

53916[TASK] Allow string as $subpartContent

Sebastian Fischer CR +2 V +2 Easy +1 −1 updated 09/05/17, 18:30

Commit message

The parameter $subpartContent of substituteSubpart() can be either
string or array. IDEs need to have both present in the comment to not
show warnings for given parameters that are correct.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jigal van Hemert +2
  • Verified V +2
    • Wouter Wolters +2
    • Jigal van Hemert +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Sebastian Fischer uploaded patch set 1 09/05/17, 14:40

  2. TYPO3com voted on patch set 1 V -1 09/05/17, 14:56 Completed build in 15m 39s on Tue, 5 Sep, 04:56 PM Test Summary: 1 of 58442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14228

  3. Mathias Brodala updated the commit message in patch set 2 09/05/17, 14:57

  4. TYPO3com voted on patch set 2 V +1 09/05/17, 15:13 Completed build in 16m 19s on Tue, 5 Sep, 05:13 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14229

  5. Jigal van Hemert commented on patch set 2 CR +2 V +2 09/05/17, 18:24

    No-brainer. No functionality changed, just PhpDoc comments.
  6. Jigal van Hemert commented on patch set 2 09/05/17, 18:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 75c66b2eac1551aa91f3cf1598d6e2a6003814e8
  7. Wouter Wolters voted on patch set 2 CR +2 V +2 09/05/17, 18:30

  8. Gerrit merged patch set 2 09/05/17, 18:30