Review TYPO3_8-7 Merged

53922[TASK] Allow string as $subpartContent

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 09/05/17, 18:38

Commit message

The parameter $subpartContent of substituteSubpart() can be either
string or array. IDEs need to have both present in the comment to not
show warnings for given parameters that are correct.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Jigal van Hemert commented on patch set 1 09/05/17, 18:24

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/05/17, 18:37 Completed build in 13m 08s on Tue, 5 Sep, 08:37 PM Test Summary: 58972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-813

  3. Wouter Wolters voted on patch set 1 CR +2 V +2 09/05/17, 18:38

  4. Gerrit merged patch set 1 09/05/17, 18:38