Review main Merged

53930[BUGFIX] Do not recalculate PIDs for every query in BE search

Susi Moog CR +2 V +2 Easy +11 −3 updated 09/22/17, 11:35

Commit message

The backend search "Show all" link recalculated allowed PIDs for
the current user for all search operations resulting in an
exponentially increasing amount of sql queries depending on the
number of pages in an installation.

As the list of allowed pages for the user does not change during
the request, it is enough to calculate it once.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • Helmut Hummel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1822

  1. Susi Moog uploaded patch set 1 09/06/17, 13:23

  2. TYPO3com voted on patch set 1 V +1 09/06/17, 13:40 Completed build in 16m 42s on Wed, 6 Sep, 03:40 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14258

  3. Helmut Hummel commented on patch set 1 09/06/17, 13:46

    AbstractDatabaseRecordList.php:1383

    I would encapsule this runtime cache in the getSearchableWebmounts method, so that it can be consumed transparently for all usages
  4. Susi Moog commented on patch set 1 09/06/17, 14:06

    AbstractDatabaseRecordList.php:1383 Reply

    yes, good idea. I'm currently talking to some people having the same issue and try to see whether the patch solves "all" the problems, will push an update after that ;)
  5. Susi Moog uploaded patch set 2 09/06/17, 14:25

  6. Helmut Hummel commented on patch set 2 09/06/17, 14:30

    AbstractDatabaseRecordList.php:1225

    I still have a question here though. you always return the same result for different arguments of this method. this might not be correct, right? at least when reading it it does not seem obvious that the final result is still correct then
  7. Susi Moog commented on patch set 2 09/06/17, 14:34

    AbstractDatabaseRecordList.php:1225 Reply

    arg, wait a second, may have pushed too early.
  8. TYPO3com voted on patch set 2 V +1 09/06/17, 14:39 Completed build in 13m 54s on Wed, 6 Sep, 04:39 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14259

  9. Susi Moog uploaded patch set 3 09/06/17, 14:44

  10. Susi Moog commented on patch set 3 09/06/17, 14:45

    @Helmut: could you take another look? I like using the runtime cache more, because it's more explicit, but I'm not sure about the identifier.
  11. Helmut Hummel commented on patch set 3 09/06/17, 14:58

    looks good now, thanks
  12. TYPO3com voted on patch set 3 V -1 09/06/17, 15:01 Completed build in 16m 33s on Wed, 6 Sep, 05:01 PM Test Summary: 1 of 58442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14260

  13. TYPO3com voted on patch set 3 V +1 09/06/17, 15:31 Completed build in 1h 02m 38s on Wed, 6 Sep, 05:31 PM Test Summary: 58079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14260

  14. Wouter Wolters voted on patch set 3 CR +1 09/06/17, 17:59

  15. Stefan Neufeind voted on patch set 3 CR +1 V +1 09/07/17, 07:16

  16. simonbrandstaetter commented on patch set 3 CR +1 V +1 09/07/17, 08:44

    Works for me!
  17. simonbrandstaetter commented on patch set 3 CR 0 V 0 09/07/17, 09:37

    -Login with non admin. show all is slow again. -Seach eg. fe users you cant search for "firstname lastname"
  18. Anja Leichsenring commented on patch set 3 CR +1 V +1 09/07/17, 20:12

    works for me. Search with spaces to more than one field (firstname lastname) will also not work before the patch.
  19. Jörg Bösche commented on patch set 3 CR +1 V +1 09/20/17, 07:37

    Tested on master and v8.7. V8.7 with more than 300 pages: Before the patch: response time >5 seconds With the patch: response time < 1 second (after PID caching)
  20. Helmut Hummel voted on patch set 3 CR +1 09/20/17, 08:46

  21. Stefan Neufeind commented on patch set 3 CR +2 V +2 09/22/17, 11:35

    enough votes :-)
  22. Gerrit merged patch set 3 09/22/17, 11:35