Review main Merged

54002[BUGFIX] Fix minor error handler code bugs

Benni Mack CR +2 V +2 Normal +24 −30 updated 09/08/17, 11:31

Commit message

ErrorHandler has a few minor quirks:

1. the protected property is an integer (bitwise-comparison) but initialized as array
2. small indention and repeatable string introduction
3. human-readable text for E_USER_DEPRECATED missing
4. error handling when no autoloader is available is obsolete.

The patch fixes all these minor issues.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Benni Mack uploaded patch set 1 09/08/17, 10:00

  2. Andreas Kienast voted on patch set 1 CR +1 09/08/17, 10:05

  3. Andreas Kienast voted on patch set 1 V +1 09/08/17, 10:10

  4. Wouter Wolters voted on patch set 1 CR +1 09/08/17, 10:16

  5. Christian Kuhn voted on patch set 1 CR -1 09/08/17, 10:20

  6. Christian Kuhn voted on patch set 1 CR +1 V +1 09/08/17, 10:23

  7. Christian Kuhn commented on patch set 1 09/08/17, 10:23

    fine with me.
  8. Helmut Hummel voted on patch set 1 CR +1 V +1 09/08/17, 10:24

  9. TYPO3com voted on patch set 1 V -1 09/08/17, 10:46 Completed build in 46m 09s on Fri, 8 Sep, 12:46 PM Test Summary: 1 of 58506 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14428

  10. Helmut Hummel commented on patch set 1 CR -2 09/08/17, 10:52

    I have a suggestion
  11. Helmut Hummel commented on patch set 1 CR 0 09/08/17, 10:53

    ah, no. all good :)
  12. TYPO3com voted on patch set 1 V +1 09/08/17, 11:24 Completed build in 2h 09m 57s on Fri, 8 Sep, 01:24 PM Test Summary: 58143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14428

  13. Benni Mack voted on patch set 1 CR +2 V +2 09/08/17, 11:25

  14. Gerrit merged patch set 1 09/08/17, 11:25

  15. Benni Mack commented on patch set 2 09/08/17, 11:31

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 87a4c9c2900f492c89e52db9cb4b1db298aad9b7