Review main Merged

54084[BUGFIX] Remove NOT NULL constraints from l1[08]n_diffsource fields

Andreas Kienast CR +2 V +2 Easy +25 −25 updated 09/10/17, 08:48

Commit message

Having NOT NULL collides with MySQL strict mode, so these constraints
get removed.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Markus Hölzle +1
  • Verified V +2
    • Benjamin Kott +2
    • Markus Hölzle +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 810

  1. Andreas Kienast uploaded patch set 1 09/09/17, 20:01

  2. Markus Hölzle voted on patch set 1 CR +1 V +1 09/09/17, 20:14

  3. Andreas Kienast updated the commit message in patch set 2 09/09/17, 20:15

  4. Benjamin Kott voted on patch set 2 CR +1 V +1 09/09/17, 20:17

  5. TYPO3com voted on patch set 1 V +1 09/09/17, 20:21 Completed build in 19m 31s on Sat, 9 Sep, 10:21 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14731

  6. Markus Hölzle voted on patch set 2 CR +1 V +1 09/09/17, 20:26

  7. TYPO3com voted on patch set 2 V +1 09/09/17, 20:36 Completed build in 21m 06s on Sat, 9 Sep, 10:36 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14735

  8. Benjamin Kott voted on patch set 2 CR +2 V +2 09/09/17, 20:38

  9. Gerrit merged patch set 2 09/09/17, 20:38

  10. Benjamin Kott commented on patch set 3 09/10/17, 08:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit fe3667267fa0d80fe1c3816e4ddfac9db5351a69