Review main Merged

54095[BUGFIX] Fix parameters in recursiveConfigurationFetching() call

Simon Praetorius CR +2 V +2 Easy +2 −1 updated 09/10/17, 13:22

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Hölzle +1
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Simon Praetorius uploaded patch set 1 09/10/17, 09:47

  2. Markus Hölzle voted on patch set 1 CR +1 09/10/17, 09:59

  3. TYPO3com voted on patch set 1 V -1 09/10/17, 10:07 Completed build in 19m 47s on Sun, 10 Sep, 12:07 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14795

  4. TYPO3com voted on patch set 1 V +1 09/10/17, 10:19 Completed build in 51m 54s on Sun, 10 Sep, 12:19 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14795

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 09/10/17, 12:35

  6. Stefan Neufeind commented on patch set 1 CR -1 09/10/17, 13:20

    But recursiveConfigurationFetching() takes 3 parameters, not 4. Or am I overlooking something?
  7. Stefan Neufeind commented on patch set 1 CR +1 09/10/17, 13:21

    all cool. didn't have current master locally
  8. Stefan Neufeind voted on patch set 1 CR +2 V +2 09/10/17, 13:22

  9. Gerrit merged patch set 1 09/10/17, 13:22