Review main Merged

54152[TASK] Streamline BackendUtility::getPagesTSconfig

Alexander Schnitzler CR +2 V +2 Normal +112 −46 updated 10/05/17, 10:46

Commit message

BackendUtility::getPagesTSconfig does accumulate the PageTS
of a page, parses and returns it. That is the main purpose of
that method. But there are 2 method arguments that change the
behavior of that method. When setting $returnPartArray to true,
the PageTS will be returned non parsed. When providing a custom
$rootLine, that rootline will be used and the result is not
cached.

1.) There is just one method call in the core that makes use
    of the argument $returnPartArray, thus, fetching the non
    parsed PageTS is made available through a separate method
    called getRawPagesTSconfig(). Using the argument
    $returnPartArray is deprecated and will be removed.

2.) Providing a custom rootline via the $rootline method is
    also deprecated and will be removed. The core does not have
    the need to fetch the PageTS for a made up rootline, thus
    people can use getRawPagesTSconfig() with a custom
    rootline in the future and then parse that PageTS
    themselves. That way the result of getPagesTSconfig can
    always be cached in the future.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4