Review TYPO3_7-6 Merged

54167[BUGFIX] Correctly handle non-existing level in menu.directory VH

Markus Klein CR +2 V +2 Easy +21 −10 updated 09/19/17, 12:20

Commit message

Providing a non-existing entry-level to the getPageUids() method
now returns an empty array instead of an array with key zero and
a null value.

This way we can correctly stop processing in the viewhelpers
using the MenuViewHelperTrait.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • Johannes Kasberger +1
  • Verified V +2
    • Oliver Hader +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Markus Klein uploaded patch set 1 09/19/17, 10:24

  2. TYPO3com voted on patch set 1 V +1 09/19/17, 10:29 Completed build in 05m 19s on Tue, 19 Sep, 12:29 PM Test Summary: 39184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1133

  3. Johannes Kasberger voted on patch set 1 CR +1 V +1 09/19/17, 10:31

  4. Stefan Neufeind voted on patch set 1 CR +1 09/19/17, 10:31

  5. Oliver Hader voted on patch set 1 CR +1 09/19/17, 12:01

  6. Oliver Hader voted on patch set 1 V +1 09/19/17, 12:05

  7. Oliver Hader voted on patch set 1 CR +2 V +2 09/19/17, 12:20

  8. Gerrit merged patch set 1 09/19/17, 12:20