Review TYPO3_8-7 Merged

54206[BUGFIX] Do not recalculate PIDs for every query in BE search

Stefan Neufeind CR +2 V +2 Easy +11 −3 updated 09/25/17, 08:56

Commit message

The backend search "Show all" link recalculated allowed PIDs for
the current user for all search operations resulting in an
exponentially increasing amount of sql queries depending on the
number of pages in an installation.

As the list of allowed pages for the user does not change during
the request, it is enough to calculate it once.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Sommer +1
    • Jan Stockfisch +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Neufeind uploaded patch set 1 09/22/17, 11:38

  2. Stefan Neufeind commented on patch set 1 CR +1 09/22/17, 11:39

    hand-picked (adapted) for 8.7
  3. TYPO3com voted on patch set 1 V +1 09/22/17, 11:53 Completed build in 14m 59s on Fri, 22 Sep, 01:53 PM Test Summary: 57518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-958

  4. Markus Sommer commented on patch set 1 CR +1 V +1 09/22/17, 12:01

    Works
  5. Jan Stockfisch voted on patch set 1 CR +1 09/25/17, 08:49

  6. Stefan Neufeind voted on patch set 1 CR +2 V +2 09/25/17, 08:56

  7. Gerrit merged patch set 1 09/25/17, 08:56