Review main Merged

54230[TASK] Remove hardcoded check on typo3/sysext/

Benni Mack CR +2 V +2 Easy +0 −7 updated 09/29/17, 15:47

Commit message

When running TYPO3 with custom components (subtree), the typo3/sysext/
directory is not always necessary, and the hardcoded check is obsolete.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 09/28/17, 14:53

  2. TYPO3com voted on patch set 1 V -1 09/28/17, 15:06 Completed build in 13m 04s on Thu, 28 Sep, 05:06 PM Test Summary: 132 of 57254 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15183

  3. TYPO3com voted on patch set 1 V +1 09/28/17, 15:35 Completed build in 54m 23s on Thu, 28 Sep, 05:35 PM Test Summary: 56895 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15183

  4. Benni Mack updated the commit message in patch set 2 09/29/17, 15:11

  5. TYPO3com voted on patch set 2 V +1 09/29/17, 15:24 Completed build in 13m 27s on Fri, 29 Sep, 05:24 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15209

  6. Frank Nägler voted on patch set 2 CR +1 V +1 09/29/17, 15:45

  7. Christian Kuhn commented on patch set 2 CR +1 V +1 09/29/17, 15:46

    SystemEnvironmentBuilder.php:201

    background: This if was basically an additional test to verify the calculated path structure is correct. It was assumed that sysext always exists. If this relaxes now and sysext may be away, we can easily drop this here.
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 09/29/17, 15:47

  9. Gerrit merged patch set 2 09/29/17, 15:47

  10. Christian Kuhn commented on patch set 3 09/29/17, 15:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f3c4f5f8a2653f3d30327a97eb6f3a5a7e307f1d