54298[BUGFIX] Add title tag to anchor in Fluid Styled Content uploads
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Jörg Bösche +1
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
- Jörg Bösche +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1214
-
Benni Mack uploaded patch set 1 10/05/17, 06:48
-
Susi Moog voted on patch set 1 CR +1 10/05/17, 06:50
-
TYPO3com voted on patch set 1 V -1 10/05/17, 06:57 Completed build in 09m 16s on Thu, 5 Oct, 08:57 AM Test Summary: 1 of 56909 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15383
-
TYPO3com voted on patch set 1 V +1 10/05/17, 07:19 Completed build in 39m 36s on Thu, 5 Oct, 09:19 AM Test Summary: 56550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15383
-
Jörg Bösche commented on patch set 1 CR +1 V +1 10/05/17, 07:19
Verified on master and v8.7.7 -
Georg Ringer commented on patch set 1 10/05/17, 07:28
IMO that leads to a XSS; why not just use the f:link.external in that case? -
Susi Moog voted on patch set 1 CR +2 V +2 10/05/17, 07:28
-
Susi Moog voted on patch set 1 CR +1 V +1 10/05/17, 07:29
-
Benni Mack voted on patch set 1 CR -2 10/05/17, 07:30
-
Benni Mack commented on patch set 1 CR 0 10/07/17, 11:39
No XSS due to the argument which is escaped (tested with "my <strong>label</strong>" - so this fix is fine for me, the external viewhelper could be changed differently so this bugfix stays as little intrusive as possible -
Stefan Neufeind voted on patch set 1 CR +1 V +1 10/07/17, 12:11
-
Benni Mack voted on patch set 1 CR +2 V +2 10/09/17, 06:24
-
Gerrit merged patch set 1 10/09/17, 06:24
-
Benni Mack commented on patch set 2 10/09/17, 06:24
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9c74924a67f98fe7b7daea1b4448c755cf46a94f