Review main Merged Breaking

54312[!!!][TASK] Deprecate ext:backend class AbstractModule

Christian Kuhn CR +2 V +2 Normal +184 −44 updated 10/06/17, 15:04

Commit message

The internal / experimental class ext:backend/Module/AbstractModule
doesn't do much useful stuff: It only instantiates ModuleTemplate
in it's constructor which forces all inheriting classes to call
parent::__construct(). The processRequest() method with its
dispatcher code is never used in core, but superseeded by routing
configuration via Configuration/Backend/Routes.php.

The patch removes given AbstractModule usages and markes the
class as deprecated. The patch is slightly breaking in cases
an extension extends AbstractWizardController and additionally
uses the initialized moduleTemplate property.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 21

Show 1 more file