Review main Merged

54369[BUGFIX] Properly detect record link dialog tab

Stanislas Rolland CR +2 V +2 Easy +1 −1 updated 10/12/17, 08:56

Commit message

RecordLinkHandler->canHandleLink should check record identifier,
otherwise the element browser may open the wrong tab when multiple
record identifiers are configured.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Stanislas Rolland uploaded patch set 1 10/11/17, 19:01

  2. TYPO3com voted on patch set 1 V -1 10/11/17, 19:01 Completed build in 08s on Wed, 11 Oct, 09:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15561

  3. Stanislas Rolland uploaded patch set 2 10/11/17, 22:18

  4. TYPO3com voted on patch set 2 V +1 10/11/17, 22:27 Completed build in 09m 28s on Thu, 12 Oct, 12:27 AM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15569

  5. Mathias Brodala commented on patch set 2 CR +1 V +1 10/12/17, 08:09

    This is wonderful. I stumbled upon this over and over again in the last days.
  6. Mathias Brodala updated the commit message in patch set 3 10/12/17, 08:10

  7. Mathias Brodala voted on patch set 3 CR +1 V +1 10/12/17, 08:10

  8. TYPO3com voted on patch set 3 V +1 10/12/17, 08:20 Completed build in 10m 11s on Thu, 12 Oct, 10:20 AM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15573

  9. Wouter Wolters voted on patch set 3 CR +1 10/12/17, 08:48

  10. Markus Klein commented on patch set 3 CR +2 V +2 10/12/17, 08:56

    Thanks a lot Stan for the fix!
  11. Gerrit merged patch set 3 10/12/17, 08:56

  12. Markus Klein commented on patch set 4 10/12/17, 08:56

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1179f1995440a5472cc23ce275fdadb26c4db043