Review main Merged

54401[TASK] Cleanup DataHandler (again)

Benni Mack CR +2 V +2 Hard +176 −245 updated 11/06/18, 14:00

Commit message

The following changes were made:

1. enableLogging is now only checked within the log methods (if no extra
CPU / DB requests were made in the if statements).

2. Introduce a getter for $GLOBALS['LANG'] instead of using the hard-coded
object (and using IF statements, although the comment on top of the
PHP class states that LanguageService MUST be initialized).

3. Simplify switch-cases / nested-if statement to a regular IF condition

4. Use Logger API instead of plain debug() calls

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1