Review main Merged

54429[BUGFIX] Allow setting translateToMessage to empty

Susi Moog CR +2 V +2 Easy +10 −6 updated 10/18/17, 06:23

Commit message

Unsetting TCEMAIN.translateToMessage was not possible
due to a default fallback to a hardcoded string in
data handler.

This patch sets the default via PageTSConfig and
simplifies the condition / fallback logic.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Susi Moog uploaded patch set 1 10/17/17, 23:08

  2. TYPO3com voted on patch set 1 V -1 10/17/17, 23:08 Completed build in 12s on Wed, 18 Oct, 01:08 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15750

  3. Christian Kuhn uploaded patch set 2 10/17/17, 23:14

  4. Oliver Hader voted on patch set 2 CR +1 10/17/17, 23:18

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 10/17/17, 23:21

  6. TYPO3com voted on patch set 2 V +1 10/17/17, 23:26 Completed build in 12m 08s on Wed, 18 Oct, 01:26 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15751

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 10/18/17, 06:23

  8. Gerrit merged patch set 2 10/18/17, 06:23