Review main Merged

54439[BUGFIX] Remove style attribute in LiveSearch

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 10/18/17, 20:06

Commit message

Currently, `beforeRender` removes some inline CSS so adjust the layout
of the suggest list. If the first search has no result, the layout is
broken because `beforeRender` is not called in case there are no results.

This patch removes the style attribute as early as possible.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 10/18/17, 19:49

  2. Wouter Wolters commented on patch set 1 CR +1 V +1 10/18/17, 19:52

    works great
  3. Mathias Schreiber voted on patch set 1 CR +1 V +1 10/18/17, 19:54

  4. TYPO3com voted on patch set 1 V +1 10/18/17, 20:01 Completed build in 11m 40s on Wed, 18 Oct, 10:01 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15777

  5. Wouter Wolters voted on patch set 1 CR +2 V +2 10/18/17, 20:06

  6. Gerrit merged patch set 1 10/18/17, 20:06

  7. Wouter Wolters commented on patch set 2 10/18/17, 20:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit cd03862c6aeadcbb2894b33735d50933b370fb3e