Review TYPO3_8-7 Merged

54440[BUGFIX] Remove style attribute in LiveSearch

Wouter Wolters CR +2 V +2 Easy +4 −2 updated 10/18/17, 20:22

Commit message

Currently, `beforeRender` removes some inline CSS so adjust the layout
of the suggest list. If the first search has no result, the layout is
broken because `beforeRender` is not called in case there are no results.

This patch removes the style attribute as early as possible.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Wouter Wolters commented on patch set 1 10/18/17, 20:06

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/18/17, 20:20 Completed build in 13m 24s on Wed, 18 Oct, 10:20 PM Test Summary: 57593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1089

  3. Wouter Wolters voted on patch set 1 CR +2 V +2 10/18/17, 20:22

  4. Gerrit merged patch set 1 10/18/17, 20:22