Review main Merged

54442[TASK] Update friendsofphp/php-cs-fixer to latest version

Wouter Wolters CR +2 V +2 Normal +117 −7 updated 10/20/17, 10:30

Commit message

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Christian Kuhn +1
  • Verified V +2
    • Benjamin Kott +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Wouter Wolters uploaded patch set 1 10/18/17, 21:16

  2. TYPO3com voted on patch set 1 V +1 10/18/17, 21:25 Completed build in 09m 06s on Wed, 18 Oct, 11:25 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15784

  3. Georg Ringer commented on patch set 1 10/19/17, 06:43

    I would like to have that in 8.7 as well to avoid possible side effects with cgl checks. what you think?
  4. Wouter Wolters commented on patch set 1 10/19/17, 06:55

    I thought about that too yesterday but I checked 8.7 and that version is already way behind. 2.5.0 is currently used in master. In 8.7 we use the 2.0 release.
  5. Wouter Wolters updated the commit message in patch set 2 10/19/17, 07:15

  6. Wouter Wolters commented on patch set 2 10/19/17, 07:15

    Seems I had not updated my 8.7 branch with a composer install. 8.7 uses 2.5.0 too at the moment.
  7. TYPO3com voted on patch set 2 V +1 10/19/17, 07:23 Completed build in 08m 16s on Thu, 19 Oct, 09:23 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15787

  8. Christian Kuhn commented on patch set 2 CR +1 V +1 10/20/17, 10:25

    executed my 'fix all core files' script which is also executed by bamboo nightly: all good, no additional findings. go from my side.
  9. Christian Kuhn commented on patch set 2 10/20/17, 10:27

    note: this brings php 7.2 compat which was one of the last blockers to execute bamboo tests on php 7.2
  10. Benjamin Kott voted on patch set 2 CR +2 V +2 10/20/17, 10:30

  11. Gerrit merged patch set 2 10/20/17, 10:30