Review main Merged

54446[FEATURE] Introduce new @import syntax for TS includes

Benni Mack CR +2 V +2 Hard +384 −0 updated 10/20/17, 13:11

Commit message

The original '<INCLUDE_TYPOSCRIPT...>' syntax is hard to understand,
error-prone and overloaded with features.

This patch introduces a new way to include files based on SymfonyFinder
and simple logic to allow to include files or folders:

The following syntax (leaned towards SASS imports) is added:
Imports one file:

- @import 'EXT:myext/Configuration/TypoScript/myfile.typoscript'

Imports all files in a folder (always sorted by name):
- @import 'EXT:myext/Configuration/TypoScript/*'
- @import 'EXT:myext/Configuration/TypoScript/'

Imports all files ending with ".typoscript":
- @import 'EXT:myext/Configuration/TypoScript/*.typoscript'

Automatically adds '.typoscript' file ending and includes setup.typoscript
- @import 'EXT:myext/Configuration/TypoScript/setup'

This is all done with Symfony Finder to find the files.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7