Review main Merged

54470[BUGFIX] Avoid race condition in JS Icon API

Tymoteusz Motylewski CR +2 V +2 Easy +12 −13 updated 10/27/17, 14:35

Commit message

Now promise is cached instead of promise result, to avoid race condition
when requesting the same icon multiple times.
Now API will do just one ajax call per icon, even if the other API call
is made before the first one finishes.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1