Review main Merged

54474[BUGFIX] Allow multiline strings in foreign_table_where

Wolfgang Klinger CR +2 V +2 Easy +8 −4 updated 10/26/17, 14:01

Commit message

Add the ’s’ (PCRE_DOTALL) modifier to regular expressions.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Wolfgang Klinger uploaded patch set 1 10/25/17, 11:48

  2. Oliver Klee commented on patch set 2 10/25/17, 11:55

    Published edit on patch set 1.
  3. Oliver Klee commented on patch set 2 10/25/17, 11:56

    I've removed the trailing whitespace. (It's common to have PhpStorm to be configured to remove trailing whitespace on save, causing changes in lines that otherwise are not touched. Not having trailing whitespace in the first place avoids this problem.)
  4. TYPO3com voted on patch set 1 V -1 10/25/17, 11:57 Completed build in 09m 19s on Wed, 25 Oct, 01:57 PM Test Summary: 2 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15869

  5. TYPO3com voted on patch set 1 V +1 10/25/17, 12:04 Completed build in 24m 49s on Wed, 25 Oct, 02:04 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15869

  6. TYPO3com voted on patch set 2 V +1 10/25/17, 12:04 Completed build in 08m 56s on Wed, 25 Oct, 02:04 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15870

  7. Markus Klein commented on patch set 2 10/25/17, 14:18

    AbstractItemProvider.php:1145

    I consider using the s modifier a bit "dangerous", I would prefer an explicit mentioning of the line breaks in the regex. By reading this would mean extending the first group should already suffice: /^((?:\n|\r\n|.)*)....
  8. Wolfgang Klinger commented on patch set 2 10/25/17, 14:59

    AbstractItemProvider.php:1145 Reply

    Thanks for your comment, can you elaborate on the "dangerous" part? I'm really curious because . is defined as 'match any character except newline (by default)' and the 's' modifier does only remove that single 'exception' (as far as I understand the official PHP documentation). And the pattern is much easier to grasp obviously.
  9. Markus Klein commented on patch set 2 CR +1 V +1 10/25/17, 15:44

    AbstractItemProvider.php:1145 Reply

    Right, I mixed something up here. Good as is, double checked now.
  10. Stefan Neufeind voted on patch set 2 CR +1 V +1 10/25/17, 20:03

  11. Georg Ringer voted on patch set 2 CR +2 V +2 10/26/17, 14:01

  12. Gerrit merged patch set 2 10/26/17, 14:01

  13. Georg Ringer commented on patch set 3 10/26/17, 14:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9738b6d580f97691b3f4a6c1eb503464635c2062