54478[BUGFIX] Allow multiline strings in foreign_table_where
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Markus Klein +1
-
Verified V +2
- Frank Nägler +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 79
-
Georg Ringer commented on patch set 1 10/26/17, 14:01
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 10/26/17, 14:16 Completed build in 15m 07s on Thu, 26 Oct, 04:16 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1115
-
Andreas Kienast commented on patch set 1 10/26/17, 14:27
TcaSelectItemsTest.php:1800Does it make sense to test both cases: with line breaks and without line breaks? -
Markus Klein commented on patch set 1 10/26/17, 16:14
TcaSelectItemsTest.php:1800ReplyI would say it's enough to test the "extended" version here. -
Markus Klein updated the commit message in patch set 2 10/26/17, 16:15
-
Markus Klein voted on patch set 2 CR +1 V +1 10/26/17, 16:15
-
TYPO3com voted on patch set 2 V +1 10/26/17, 16:27 Completed build in 12m 39s on Thu, 26 Oct, 06:27 PM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1116
-
Frank Nägler voted on patch set 2 CR +2 V +2 10/27/17, 12:22
-
Gerrit merged patch set 2 10/27/17, 12:22