Review main Merged

54543[BUGFIX] FormEngine: returnUrl handling in inline

Christian Kuhn CR +2 V +2 Easy +23 −9 updated 11/03/17, 14:21

Commit message

If an inline child, opened via ajax request, generates links leaving
the current records and opening a different one, on closing that
record the returnUrl is wrong and points to the url of the inline
ajax request.
The original return url of the main record is lost in the compile chain.
The returnUrl data provider sets $data['returnUrl'] to current url if not
otherwise given.
The patch hands over the original return url to the inline ajax controller
and lets it 'sink down' in the data compile chain to inline children so
the original return url is available when container or elements generate urls.
Additionally some broken 'returnURL' handling in InlineRecordContainer
and jsfunc.inline.js is cleaned up and removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5