Review main Merged

54545[TASK] Remove TypoScript option config.typolinkCheckRootline

Benni Mack CR +2 V +2 Easy +36 −13 updated 11/03/17, 16:37

Commit message

The TypoScript option 'config.typolinkCheckRootline' was introduced
back in TYPO3 v4.x when there was no proper rootline cache or sys_domain
cache in place, in order to resolve the proper domain.

This now has changed, and this option can be removed in order to simplify
page link generation.

When in a multi-site setup, this option MUST be active otherwise it will
result in ugly and hard-to-debug side-effects.

For a single-site setup having this option disabled will result in a marginal
performance decrease (one SQL query more) when linking to a page with a
sys_domain record available.

A deprecation notice is thrown if your TypoScript setup still includes this option.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5