Review main Merged

54551Revert "[BUGFIX] Set _localizedUid in OriginColumnName"

Helmut Hummel CR +2 V +2 Easy +3 −3 updated 11/04/17, 18:45

Commit message

This reverts commit 68e8530319faea18fbc61eee55fc00298582e8de.

The patch needs to be reverted due to wrong implementation.
The desired goal is not achievable at all with the current code base.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Files 2

Review log 1114

  1. Helmut Hummel uploaded patch set 1 11/04/17, 00:59

  2. TYPO3com voted on patch set 1 V +1 11/04/17, 01:10 Completed build in 11m 03s on Sat, 4 Nov, 02:10 AM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16063

  3. Markus Klein voted on patch set 1 CR +1 V +1 11/04/17, 09:42

  4. Markus Klein commented on patch set 1 CR -1 V 0 11/04/17, 09:47

    the commit msg needs some more info. will improve asap
  5. Markus Klein updated the commit message in patch set 2 11/04/17, 10:12

  6. Markus Klein voted on patch set 2 CR +1 V +1 11/04/17, 10:12

  7. Andreas Kienast updated the commit message in patch set 3 11/04/17, 10:13

  8. Markus Klein commented on patch set 3 CR +1 V +1 11/04/17, 10:17

    Thx Andy, was about to correct that too ;-)
  9. Wouter Wolters voted on patch set 3 CR +1 11/04/17, 10:21

  10. TYPO3com voted on patch set 2 V +1 11/04/17, 10:24 Completed build in 12m 21s on Sat, 4 Nov, 11:24 AM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16065

  11. TYPO3com voted on patch set 3 V +1 11/04/17, 10:25 Completed build in 11m 11s on Sat, 4 Nov, 11:25 AM Test Summary: 56750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16066

  12. Nicole Hummel voted on patch set 3 CR +1 V +1 11/04/17, 18:18

  13. Markus Klein voted on patch set 3 CR +2 V +2 11/04/17, 18:45

  14. Gerrit merged patch set 3 11/04/17, 18:45