Review main Merged

54618[TASK] Deprecate usage of @inject with non-public properties

Alexander Schnitzler CR +2 V +2 Normal +65 −0 updated 11/14/17, 06:42

Commit message

When using private or protected properties for Dependency Injection
via `@inject`, Extbase needs to use the object reflection API to
make these properties settable from the outside, which is quite
slow and cannot be cached in any way. Therefore property injection
should only work for public properties.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2