Review main Abandoned

54620[WIP][BUGFIX] Fix RTE CKeditor placements of dropdowns in Chrome

Riccardo De Contardi CR 0 V 0 Easy +9 −8 updated 02/10/18, 15:52

Commit message

When used with Chrome browser, RTE CKEditor misplaces the position of
its dropdowns opened via right-click when the viewport is scrolled;
also, the maximize feature does not work
correctly and places the button bar outside the view.

The reason for that is a hack that was intended to "Prevent Browser
Rebounce", introduced in I6d9c6c4e32cf67df3eeb072448e6b4322853d10c.
That patch made <body> exactly 100% in height and moved the scroll
bar from <html> to <body>.
That caused CKeditors dropdowns – which are placed
absolutely as childrens of <body> – to be placed at the mathematical
bottom of <body>. Due tue the "Browser Rebouce" fix the body is too
short. It's 100% of the viewport instead of 100%
of the actual content. That caused Chrome to scroll up
to show the focussed dropdowns.

By removing that hack (reverting back to browser defaults)
we can fix the misplacements because body is no longer
"too short" for CKeditors absolutely positioned
dropdowns.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3