Review main Merged Breaking

54634[!!!][TASK] Remove BE/fileExtensions/webspace

Benni Mack CR +2 V +2 Normal +56 −100 updated 11/28/17, 22:41

Commit message

The option $TYPO3_CONF_VARS[BE][fileExtensions][webspace][*]
is removed.

It was only used in some specific cases, whereas fileDenyPattern usage
is more consistently done and replaces this setting.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2536

Show 711 earlier messages
  1. Benni Mack uploaded patch set 1 11/14/17, 06:48

  2. TYPO3com voted on patch set 1 V -1 11/14/17, 06:48 Completed build in 09s on Tue, 14 Nov, 07:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16310

  3. Benni Mack uploaded patch set 2 11/14/17, 06:48

  4. TYPO3com voted on patch set 2 V +1 11/14/17, 06:57 Completed build in 08m 55s on Tue, 14 Nov, 07:57 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16311

  5. Benni Mack updated the commit message in patch set 3 11/24/17, 20:55

  6. TYPO3com voted on patch set 3 V +1 11/24/17, 21:04 Completed build in 09m 35s on Fri, 24 Nov, 10:04 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16593

  7. Benni Mack uploaded patch set 4 11/27/17, 16:04

  8. TYPO3com voted on patch set 4 V +1 11/27/17, 16:19 Completed build in 15m 09s on Mon, 27 Nov, 05:19 PM Test Summary: 56816 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16688

  9. Sebastian Hofer voted on patch set 4 CR +1 11/27/17, 20:48

  10. Jörg Bösche voted on patch set 4 CR +1 11/28/17, 06:20

  11. Henning Liebe voted on patch set 4 CR +1 11/28/17, 08:19

  1. Susi Moog commented on patch set 4 CR -1 11/28/17, 11:42

    ArrayDimensionMatcher.php:127

    fileExtensions
  2. Susi Moog uploaded patch set 5 11/28/17, 12:34

  3. Susi Moog updated the commit message in patch set 6 11/28/17, 12:35

  4. TYPO3com voted on patch set 5 V +1 11/28/17, 12:51 Completed build in 17m 17s on Tue, 28 Nov, 01:51 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16810

  5. TYPO3com voted on patch set 6 V +1 11/28/17, 12:54 Completed build in 18m 30s on Tue, 28 Nov, 01:54 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16811

  6. Tomas Norre Mikkelsen commented on patch set 6 11/28/17, 14:29

    BasicFileUtility.php:72

    Will this not conflict as allow and deny has the same value ?
  7. Susi Moog commented on patch set 7 11/28/17, 14:35

    Published edit on patch set 6.
  8. Susi Moog commented on patch set 7 11/28/17, 14:35

    BasicFileUtility.php:72 Reply

    good point.
  9. Tomas Norre Mikkelsen voted on patch set 7 CR +1 11/28/17, 14:44

  10. TYPO3com voted on patch set 7 V +1 11/28/17, 14:49 Completed build in 13m 59s on Tue, 28 Nov, 03:49 PM Test Summary: 56852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16825

  11. Christian Kuhn commented on patch set 7 CR -1 11/28/17, 14:51

    should have an update since the setting is now removed entirely.
  12. Susi Moog uploaded patch set 8 11/28/17, 16:57

  13. TYPO3com voted on patch set 8 V -1 11/28/17, 17:07 Completed build in 10m 29s on Tue, 28 Nov, 06:07 PM Test Summary: 8 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16844

  14. TYPO3com commented on patch set 8 11/28/17, 19:23 Completed build in 2h 36m 33s on Tue, 28 Nov, 08:23 PM Test Summary: 8 of 57211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16844

  15. Christian Kuhn commented on patch set 8 CR -1 11/28/17, 19:27

    SilentConfigurationUpgradeService.php:152

    no such method ;)
  16. Christian Kuhn commented on patch set 8 11/28/17, 19:27

    will push update
  17. Christian Kuhn uploaded patch set 9 11/28/17, 19:28

  18. TYPO3com voted on patch set 9 V +1 11/28/17, 19:37 Completed build in 09m 02s on Tue, 28 Nov, 08:37 PM Test Summary: 56868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16857

  19. Benni Mack commented on patch set 9 CR -1 11/28/17, 19:39

    BasicFileUtility.php:70

    can't we get rid of the constructor? Also, the comment above can be removed.

    Breaking-83081-RemovedConfigurationOptionBeFileExtensionsWebspace.rst:35

    should be automatically removed, right?
  20. Susi Moog uploaded patch set 10 11/28/17, 21:10

  21. TYPO3com voted on patch set 10 V +1 11/28/17, 21:19 Completed build in 09m 28s on Tue, 28 Nov, 10:19 PM Test Summary: 56868 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16869

  22. Benni Mack voted on patch set 10 CR +1 V +1 11/28/17, 22:05

  23. Christian Kuhn voted on patch set 10 CR +1 V +1 11/28/17, 22:40

  24. Susi Moog voted on patch set 10 CR +2 V +2 11/28/17, 22:41

  25. Gerrit merged patch set 10 11/28/17, 22:41