Review main Merged

54753[TASK] Use general functionality for fetching templates

Benni Mack CR +2 V +2 Easy +7 −25 updated 11/27/17, 17:00

Commit message

Some places in the TYPO3 Core can use the general coding functionality
to fetch absolute URLs, but "GeneralUtility::getFileAbsFileName" should
be used in these places.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 11/24/17, 22:27

  2. TYPO3com voted on patch set 1 V -1 11/24/17, 22:39 Completed build in 10m 59s on Fri, 24 Nov, 11:39 PM Test Summary: 6 of 57161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16604

  3. Benni Mack uploaded patch set 2 11/27/17, 12:44

  4. TYPO3com voted on patch set 2 V +1 11/27/17, 12:55 Completed build in 10m 11s on Mon, 27 Nov, 01:55 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16655

  5. Georg Ringer voted on patch set 2 CR +1 V +1 11/27/17, 14:04

  6. Susi Moog voted on patch set 2 CR +2 V +2 11/27/17, 17:00

  7. Gerrit merged patch set 2 11/27/17, 17:00