Review TYPO3_7-6 Abandoned

54819[BUGFIX] check if queryParts are an array, before count

Fabian Auer CR 0 V 0 Easy +5 −1 updated 12/04/17, 14:44

Commit message

In php 7.2 count works only on arrays/objects. If queryParts is empty error is thrown.
Insert condition to check if array.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 34

  1. Fabian Auer uploaded patch set 1 11/28/17, 09:42

  2. TYPO3com voted on patch set 1 V +1 11/28/17, 09:49 Completed build in 06m 15s on Tue, 28 Nov, 10:49 AM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1207

  3. Christian Kuhn commented on patch set 1 12/04/17, 14:43

    Thanks for your patch Fabian. I was not aware you fixed that issue and had a pending patch before i created https://forge.typo3.org/issues/83196 and merged patches https://review.typo3.org/#/c/54911/ (v8) and https://review.typo3.org/#/c/54912/ (v7) yesterday. I hope it is ok if I abandon this one now since it is already taken care off. I'll have a better look on pending patches next time, found your php-cs-fixer patch and updated it.
  4. Christian Kuhn abandoned the change 12/04/17, 14:44