Review main Merged

54941[BUGFIX] Proper checks for system maintainers

Georg Ringer CR +2 V +2 Easy +6 −3 updated 12/06/17, 20:50

Commit message

Always use the original user id and never use a fallback to a user id
switched to.

The BackendUserAuthentication->isSystemMaintainer() method now always
returns false if a user is in "switch user" mode.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Georg Ringer uploaded patch set 1 12/06/17, 08:37

  2. TYPO3com voted on patch set 1 V -1 12/06/17, 08:46 Completed build in 09m 46s on Wed, 6 Dec, 09:46 AM Test Summary: 1 of 57358 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17217

  3. Benni Mack commented on patch set 1 12/06/17, 10:08

    BackendUserAuthentication.php:469

    this ain't casted (int)
  4. Andreas Kienast commented on patch set 2 12/06/17, 18:33

    Published edit on patch set 1.
  5. Benni Mack commented on patch set 2 12/06/17, 18:39

    Chickend + Egg problem. Patch solves the following issue: - I am a system maintainer and switch to ANY user, the menu items are shown Current (running) solves the following issue: If you are an admin user WITHOUT system maintainer access, switching to another admin WITH system maintainer access, you do NOT get to see them. The patch reverses this concept.
  6. TYPO3com voted on patch set 2 V +1 12/06/17, 18:44 Completed build in 10m 53s on Wed, 6 Dec, 07:44 PM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17260

  7. Andreas Kienast uploaded patch set 3 12/06/17, 19:01

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 12/06/17, 19:09

  9. TYPO3com voted on patch set 3 V +1 12/06/17, 19:10 Completed build in 09m 00s on Wed, 6 Dec, 08:10 PM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17264

  10. Markus Klein voted on patch set 3 CR +1 12/06/17, 19:52

  11. Benni Mack voted on patch set 3 CR +2 V +2 12/06/17, 20:50

  12. Gerrit merged patch set 3 12/06/17, 20:50