Review main Merged

55003[TASK] ResourceViewHelper should always return absolute paths

Benni Mack CR +2 V +2 Easy +3 −3 updated 12/09/17, 22:38

Commit message

The ResourceViewHelper had a special handling for returning relative
paths, but should always use getAbsoluteWebPath().

The option "absolute" is there to generate a full URL, so this is no issue at all.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 12/09/17, 19:06

  2. TYPO3com voted on patch set 1 V +1 12/09/17, 19:16 Completed build in 09m 32s on Sat, 9 Dec, 08:16 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17478

  3. Benni Mack uploaded patch set 2 12/09/17, 20:14

  4. Susi Moog voted on patch set 2 CR +1 12/09/17, 20:18

  5. TYPO3com voted on patch set 2 V -1 12/09/17, 20:24 Completed build in 09m 56s on Sat, 9 Dec, 09:24 PM Test Summary: 2 of 57396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17484

  6. Benni Mack uploaded patch set 3 12/09/17, 21:12

  7. TYPO3com voted on patch set 3 V +1 12/09/17, 21:23 Completed build in 11m 09s on Sat, 9 Dec, 10:23 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17493

  8. Susi Moog voted on patch set 3 CR +1 V +1 12/09/17, 21:28

  9. Frank Nägler voted on patch set 3 CR +1 12/09/17, 22:34

  10. Frank Nägler voted on patch set 3 CR +2 V +2 12/09/17, 22:38

  11. Gerrit merged patch set 3 12/09/17, 22:38