Review main Merged

55121[TASK] CGL fix core after php-cs-fixer 2.9.0 raise

Christian Kuhn CR +2 V +2 Easy +0 −3 updated 12/16/17, 15:07

Commit message

The "self_accessor" fixer is more strict with younger
php-cs-fixer releases and changes method argument type
hints to self if a class object of the same class is
expected. It also changes return type hints to self
in this case.
This fixer now may collide with the "xclass" system
of the core and is thus deactivated. We shoud decide
manually if self or class name is used.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3