Review main Merged

55122[BUGFIX] Do not try to fetch additionalFields for invalid tasks

Stephan Großberndt CR +2 V +2 Normal +27 −25 updated 01/04/18, 13:07

Commit message

A task may be invalid when editing so there is no instance of
AbstractTask in $task. With this patch the SchedulerModuleController no
longer tries to add the additionalFields for that as the
AdditionalFieldProviders expect a valid task object when being called on
edit.

Additionally some cleanup in the PHPDoc of AdditionalFieldProviders is
made to make it clear the given task may be NULL on create.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6