Review TYPO3_7-6 Merged

55187[BUGFIX] Add `controlsList` as known additional attribute

Stefan Neufeind CR +2 V +2 Normal +78 −104 updated 12/21/17, 14:55

Commit message

The HTML5 attribute `controlsList` is used in at least Google Chrome
to limit the control buttons. The AudioTagRenderer and VideoTagRenderer
classes are now aware of that attribute.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1

Issues 1

Files 4

Review log 8

  1. Stefan Neufeind uploaded patch set 1 12/21/17, 13:18

  2. Stefan Neufeind commented on patch set 1 12/21/17, 13:19

    hand-picked from 8.7 due to tests not cleanly cherry-picking
  3. Markus Klein voted on patch set 1 V +1 CR +1 12/21/17, 13:39

  4. Jigal van Hemert voted on patch set 1 V +2 CR +2 12/21/17, 14:20

  5. Jigal van Hemert merged patch set 2 12/21/17, 14:20

  6. Jigal van Hemert commented on patch set 2 12/21/17, 14:21

    Ehmm... is TYPO3.com not voting?
  7. Stephan Großberndt commented on patch set 2 12/21/17, 14:54

    Fatal error: Call to undefined method TYPO3\CMS\Core\Tests\Unit\Resource\Rendering\AudioTagRendererTest::createMock() in /home/travis/build/TYPO3/TYPO3.CMS/typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php on line 109