Review main Abandoned

55218[WIP][FEATURE] Integrate symfony/event-dispatcher

Benni Mack CR 0 V 0 Hard +207 −64 updated 05/10/18, 15:01

Commit message

This is a PoC to see if we could use symfony's event dispatcher
natively and what needs to be extended from our case.

Event listeners are registered in
EXT:myextension/Configuration/EventListeners.php for now.

Still open:
- Sorting/Prioritization - needs a decision if we want to
add sorting to the Listeners.
- The EventDispatcher is now immutable, should be discussed if we want
to do that.
- Should we add our own "GenericEvent", simply calling it "Event"?

We also need examples on how to use the event dispatcher in different scenarios
in a full documentation, and also when it makes sense to have custom Events.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 5