Review main Merged

55259[FEATURE] Provide setting to hide restricted columns in page module

Steffen Kamper CR +2 V +2 Normal +46 −5 updated 02/23/18, 14:17

Commit message

The following TSConfig setting hides columns restricted via
mod.SHARED.colPos_list:

mod.web_layout.hideRestrictedCols = 1

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Sascha Rademacher +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2236

Show 711 earlier messages
  1. Steffen Kamper uploaded patch set 1 01/04/18, 09:12

  2. TYPO3com voted on patch set 1 V +1 01/04/18, 09:20 Completed build in 07m 31s on Thu, 4 Jan, 10:20 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18060

  3. Andreas Kienast commented on patch set 1 CR -1 01/04/18, 09:25

    Please do not change the backend.css file directly. Change the SASS file and compile the CSS properly by executing `grunt css` in the `Build` directory.
  4. Andreas Kienast commented on patch set 1 01/04/18, 09:28

    PageLayoutView.php:1161 Unresolved

    You may do a bool cast instead

    Feature-83460-HideRestrictedColumns.rst:25 Unresolved

    Copy paste bug?
  5. Steffen Kamper uploaded patch set 2 01/04/18, 09:59

  6. Andreas Kienast commented on patch set 2 CR -1 01/04/18, 10:06

    on it
  7. TYPO3com voted on patch set 2 V +1 01/04/18, 10:09 Completed build in 09m 49s on Thu, 4 Jan, 11:09 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18065

  8. Andreas Kienast uploaded patch set 3 01/04/18, 10:12

  9. TYPO3com voted on patch set 3 V +1 01/04/18, 10:21 Completed build in 09m 43s on Thu, 4 Jan, 11:21 AM Test Summary: 29999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18068

  10. Mathias Schreiber uploaded patch set 4 02/06/18, 21:12

  11. TYPO3com voted on patch set 4 V +1 02/06/18, 21:18 Completed build in 06m 27s on Tue, 6 Feb, 10:19 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19045

  1. Mathias Schreiber uploaded patch set 5 02/06/18, 21:23

  2. Mathias Schreiber updated the commit message in patch set 6 02/06/18, 21:26

  3. Mathias Schreiber uploaded patch set 7 02/06/18, 21:27

  4. Anja Leichsenring voted on patch set 7 V +1 CR +1 02/06/18, 21:31

  5. TYPO3com voted on patch set 5 V +1 02/06/18, 21:34 Completed build in 10m 26s on Tue, 6 Feb, 10:34 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19046

  6. TYPO3com voted on patch set 6 V +1 02/06/18, 21:37 Completed build in 10m 57s on Tue, 6 Feb, 10:37 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19047

  7. TYPO3com voted on patch set 7 V +1 02/06/18, 21:38 Completed build in 10m 52s on Tue, 6 Feb, 10:38 PM Test Summary: 30458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19048

  8. Mathias Schreiber uploaded patch set 8 02/07/18, 19:43

  9. TYPO3com voted on patch set 8 V +1 02/07/18, 19:51 Completed build in 08m 26s on Wed, 7 Feb, 08:51 PM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19092

  10. Anja Leichsenring uploaded patch set 9 02/08/18, 20:47

  11. TYPO3com voted on patch set 9 V +1 02/08/18, 20:56 Completed build in 09m 03s on Thu, 8 Feb, 09:56 PM Test Summary: 30467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19170

  12. Mathias Schreiber voted on patch set 9 V +1 CR +1 02/08/18, 21:23

  13. Anja Leichsenring voted on patch set 9 V +1 CR +1 02/08/18, 21:23

  14. Mathias Schreiber uploaded patch set 10 02/10/18, 09:56

  15. TYPO3com voted on patch set 10 V +1 02/10/18, 10:05 Completed build in 09m 03s on Sat, 10 Feb, 11:05 AM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19262

  16. Mathias Schreiber uploaded patch set 11 02/10/18, 17:37

  17. TYPO3com voted on patch set 11 V +1 02/10/18, 17:45 Completed build in 08m 01s on Sat, 10 Feb, 06:45 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19296

  18. Mathias Schreiber uploaded patch set 12 02/12/18, 20:04

  19. TYPO3com voted on patch set 12 V -1 02/12/18, 20:13 Completed build in 08m 29s on Mon, 12 Feb, 09:13 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19403

  20. TYPO3com commented on patch set 12 02/12/18, 20:15 Completed build in 19m 11s on Mon, 12 Feb, 09:15 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19403

  21. TYPO3com voted on patch set 12 V +1 02/12/18, 20:19 Completed build in 33m 33s on Mon, 12 Feb, 09:19 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19403

  22. Mathias Schreiber voted on patch set 12 V +1 CR +1 02/18/18, 14:12

  23. Sascha Rademacher voted on patch set 12 CR +1 02/19/18, 08:57

  24. Frank Nägler voted on patch set 12 V +2 CR +2 02/23/18, 14:17

  25. Frank Nägler merged patch set 13 02/23/18, 14:17