Review TYPO3_8-7 Merged

55276[BUGFIX] Add missing htmlspecialchars() in ActionTask

Stefan Neufeind CR +2 V +2 Easy +25 −23 updated 01/08/18, 20:26

Commit message

Add missing htmlspecialchars() calls in
EXT:sys_action/Classes/ActionTask.php

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Stephan Großberndt +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1721

  1. Stefan Neufeind uploaded patch set 1 01/05/18, 12:40

  2. Stefan Neufeind commented on patch set 1 01/05/18, 12:41

    hand-redone for 8.7. please check
  3. Oliver Klee voted on patch set 1 CR +1 01/05/18, 12:43

  4. TYPO3com voted on patch set 1 V +1 01/05/18, 12:46 Completed build in 05m 11s on Fri, 5 Jan, 01:46 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1617

  5. Stephan Großberndt commented on patch set 1 CR -1 01/05/18, 12:50

    ActionTask.php:944

    $uriBuilder is undefined
  6. Stefan Neufeind uploaded patch set 2 01/05/18, 17:33

  7. Stephan Großberndt commented on patch set 2 01/05/18, 17:39

    ActionTask.php:918

    Sorry Stefan, I should have written more than that. Rather than introduction uriBuilder here (in a different way than on master) I would opt for further usage of BackendUtility instead. This patch aims at htmlspecialchars.
  8. TYPO3com voted on patch set 2 V +1 01/05/18, 17:47 Completed build in 13m 16s on Fri, 5 Jan, 06:47 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1618

  9. Stefan Neufeind uploaded patch set 3 01/06/18, 14:50

  10. Stefan Neufeind commented on patch set 3 01/06/18, 14:50

    yes, agreed. now with BackendUtility
  11. TYPO3com voted on patch set 3 V +1 01/06/18, 14:59 Completed build in 09m 13s on Sat, 6 Jan, 03:59 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1619

  12. Oliver Klee voted on patch set 3 CR +1 01/06/18, 15:19

  13. Alexander Opitz commented on patch set 3 CR -1 01/08/18, 10:08

    Only the small indentation bug (master patch has this indentation issue in reverse ;-) )

    ActionTask.php:944

    Indentation failure?
  14. Stephan Großberndt uploaded patch set 4 01/08/18, 12:15

  15. Stephan Großberndt voted on patch set 4 CR +1 01/08/18, 12:16

  16. TYPO3com voted on patch set 4 V +1 01/08/18, 12:28 Completed build in 12m 45s on Mon, 8 Jan, 01:28 PM Test Summary: 57831 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1624

  17. Alexander Opitz voted on patch set 4 V +1 CR +2 01/08/18, 13:07

  18. Oliver Klee voted on patch set 4 CR +1 01/08/18, 13:12

  19. Stefan Neufeind voted on patch set 4 CR +1 01/08/18, 13:16

  20. Christian Kuhn voted on patch set 4 V +2 CR +2 01/08/18, 20:26

  21. Christian Kuhn merged patch set 5 01/08/18, 20:26