Review main Merged

55318[BUGFIX] Show folder meta information next to path

Wolfgang Klinger CR +2 V +2 Easy +13 −1 updated 01/13/18, 13:50

Commit message

Output folder meta information (file count and
total file size) next to the folder path in Filelist again.
Additionally fix a typo in a condition above.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Wolfgang Klinger uploaded patch set 1 01/10/18, 11:15

  2. Wolfgang Klinger updated the commit message in patch set 2 01/10/18, 11:15

  3. TYPO3com voted on patch set 1 V +1 01/10/18, 11:24 Completed build in 09m 07s on Wed, 10 Jan, 12:24 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18212

  4. TYPO3com voted on patch set 2 V +1 01/10/18, 11:24 Completed build in 09m 07s on Wed, 10 Jan, 12:24 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18213

  5. Frans Saris commented on patch set 2 01/10/18, 12:07

    MetaInformation.php:167

    No need to have multiple return types. Just always return a string.
  6. Wolfgang Klinger uploaded patch set 3 01/10/18, 12:39

  7. TYPO3com voted on patch set 3 V +1 01/10/18, 12:47 Completed build in 08m 02s on Wed, 10 Jan, 01:47 PM Test Summary: 30003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18215

  8. Anja Leichsenring commented on patch set 3 V +1 CR +1 01/13/18, 11:40

    Wolfgang, it would be helpful if you provided screenshots or clear descriptions what part of the backend your changes apply to. I had to look for it for a while. There are screenshots now in the ticket.
  9. Wolfgang Klinger commented on patch set 3 01/13/18, 11:46

    Thanks, I will consider next time.

    MetaInformation.php:167 Reply Unresolved

    All the other public methods in this class do it like this, but I changed it for this one now … ok
  10. Oliver Klee commented on patch set 4 01/13/18, 11:53

    Published edit on patch set 3.
  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 01/13/18, 11:57

  12. TYPO3com voted on patch set 4 V +1 01/13/18, 12:01 Completed build in 08m 33s on Sat, 13 Jan, 01:01 PM Test Summary: 28750 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18274

  13. Christian Kuhn commented on patch set 4 V +1 CR +1 01/13/18, 13:45

    debugged around a bit on the additionalInfo variable, this one is only set in filelist module. the change in the global DocHeader.html thus looks fine to me and shouldn't have negative impact.
  14. Mathias Schreiber voted on patch set 4 V +1 CR +1 01/13/18, 13:48

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 01/13/18, 13:50

  16. Christian Kuhn merged patch set 5 01/13/18, 13:50

  17. Christian Kuhn commented on patch set 5 01/13/18, 13:50

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6936c8b5d94c702920b2ddec7050313aeb8a7d3e