55362[TASK] Move EditRecordViewHelper from sysext:beuser to sysext:backend
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/backend/Classes/ViewHelpers/EditRecordViewHelper.phprenamed+6 −4
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+3 −3
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/IndexListRow.html+4 −3
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+1 −1
Review log 1928
Show 23 earlier messages
-
Reiner Teubner uploaded patch set 1 01/15/18, 10:20
-
TYPO3com voted on patch set 1 V +1 01/15/18, 10:24 Completed build in 04m 19s on Mon, 15 Jan, 11:24 AM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18331
-
Reiner Teubner uploaded patch set 2 01/15/18, 11:19
-
TYPO3com voted on patch set 2 V -1 01/15/18, 11:19 Completed build in 09s on Mon, 15 Jan, 12:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18333
-
Reiner Teubner uploaded patch set 3 01/15/18, 11:35
-
TYPO3com voted on patch set 3 V -1 01/15/18, 11:35 Completed build in 08s on Mon, 15 Jan, 12:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18334
-
Reiner Teubner uploaded patch set 4 01/15/18, 11:38
-
TYPO3com voted on patch set 4 V +1 01/15/18, 11:46 Completed build in 07m 35s on Mon, 15 Jan, 12:46 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18335
-
Reiner Teubner uploaded patch set 5 01/15/18, 13:19
-
TYPO3com voted on patch set 5 V +1 01/15/18, 13:23 Completed build in 03m 55s on Mon, 15 Jan, 02:23 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18338
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 01/15/18, 15:11
-
Wouter Wolters commented on patch set 5 CR -1 01/15/18, 15:33
IMO we can just remove the beuser ViewHelper directly. We did this with other ViewHelpers marked as @internal too in the past. These ViewHelpers are not public API. -
Anja Leichsenring commented on patch set 5 01/15/18, 16:53
> Patch Set 5: Code-Review-1 > > IMO we can just remove the beuser ViewHelper directly. We did this with other ViewHelpers marked as @internal too in the past. These ViewHelpers are not public API. We did this on intention: the VH might be used, internal or not, because it is the single one available in the BE. I is just a nice touch for the user, instead simply breaking their BE Modules. On the other hand, Reiner wanted practice in deprecation stuff, so this presented itself. -
Wouter Wolters commented on patch set 5 01/15/18, 17:37
> Patch Set 5: > > > Patch Set 5: Code-Review-1 > > > > IMO we can just remove the beuser ViewHelper directly. We did this with other ViewHelpers marked as @internal too in the past. These ViewHelpers are not public API. > > We did this on intention: the VH might be used, internal or not, because it is the single one available in the BE. I is just a nice touch for the user, instead simply breaking their BE Modules. > > On the other hand, Reiner wanted practice in deprecation stuff, so this presented itself. To me this is giving a bad signal to our users. We say the ViewHelpers are internal and when we want to delete it we can delete it. Now we are trying to make an exception which can be a signal that we are going to deprecate internal ViewHelpers in the future. IMO we need to prevent this signal to our users. -
Reiner Teubner rebased onto patch set 6 01/16/18, 13:06
-
TYPO3com commented on patch set 6 01/16/18, 13:14 Completed build in 07m 22s on Tue, 16 Jan, 02:14 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18357
-
Reiner Teubner uploaded patch set 7 01/16/18, 13:43
-
TYPO3com voted on patch set 7 V +1 01/16/18, 13:53 Completed build in 09m 21s on Tue, 16 Jan, 02:53 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18370
-
Reiner Teubner rebased onto patch set 8 01/16/18, 14:01
-
TYPO3com commented on patch set 8 01/16/18, 14:08 Completed build in 07m 35s on Tue, 16 Jan, 03:08 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18371
-
Reiner Teubner commented on patch set 9 01/16/18, 16:58
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V +1 01/16/18, 17:07 Completed build in 08m 31s on Tue, 16 Jan, 06:07 PM Test Summary: 30058 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18378
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 01/17/18, 08:25
-
Reiner Teubner commented on patch set 9 01/17/18, 08:32
> Patch Set 9: Published edit on patch set 8. Remove deprecate class (incl. matcher rule + rst info file) -
Wouter Wolters voted on patch set 9 CR +1 01/17/18, 10:17
-
Christian Kuhn voted on patch set 9 CR -1 01/17/18, 13:01
-
Christian Kuhn commented on patch set 9 01/17/18, 13:08
Hey, I think this patch is only half-baked and we should fully clean that up. There is a much longer list of VH's that don't do much more than just creating a URI to some BE module: At first glance, I found these: * backend ModuleLinkViewHelper - Nearly identical to beuser EditRecordVH and slightly more generic since it accepts the route name instead of hard coding record_edit * filelist EditFileContentViewHelper, EditSysMetadataViewHelper, RenameFileViewHelper, ReplaceFileViewHelper - all of these could probably just use ModuleLinkVH * scheduler ModuleLinkViewHelper - could use backend ModuleLinkViewHelper instead, I think, looks as if this one is just a more specific version * beuser EditReordViewHelper - could use backend ModuleLinkViewHelper instead * sys_note EditLinkViewHelper - again a more specific version of ModuleLinkViewHelper * more? check that, please. So, in the end, if we konsolidate this, I'd opt to have a more detailed look if we could just refactor all usages to ModuleLinkViewHelper of ext:backend and remove all the others. This would reduce this code duplication once and for all and we'd end up with a good bunch of core examples on how to properly create BE links from fluid. What do you think? -
Reiner Teubner abandoned the change 01/17/18, 16:57
Concept does not work out. We go back to the drawing board.